Return false instead of panicking in PublicKey::verify_signature - #19
Merged
Conversation
Member
|
Thanks! Re. CHANGELOG, it looks like I forgot to push the release commit (the one that the v0.2.0 tag points to). Should be fixed now (so that v0.2.0 is actually reachable from main). Could you rebase this on top? I may have misunderstood your comment, but the changelog does mention the built-in policies:
|
faern
force-pushed
the
no-panic-on-key-validation
branch
2 times, most recently
from
February 18, 2026 15:24
f387ab7 to
1116f31
Compare
faern
force-pushed
the
no-panic-on-key-validation
branch
from
February 18, 2026 15:24
1116f31 to
5e64c27
Compare
Author
You are right. Misunderstanding on my part. I thought version 0.1.0 had the policies, but just not the statics that I added in #12. But since none of that was part of 0.1.0 it's not a change between the versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed AFK. We do not want panics. The reference
sigsum-gojust return false in this case also.I do not think the changelog for the
0.2.0version is complete? It does for example not mention the public constant built in policies. But that's unrelated to this PR and should not be fixed here. I just went ahead and added the changelog header, to be able to separate this change from the ones in the previous release.This is related to #15